Shipment API in Magento 1.4.1 broken

Alerted by a customer comment I discovered a nasty bug in the latest Magento release. All shipments submitted through the API are handled as if you had submitted an invoice!

Looking at the method prepareShipment in
app/code/core/Mage/Sales/Model/Order.php

    /**
     * Create new shipment with maximum qty for shipping for each item
     *
     * @return Mage_Sales_Model_Order_Shipment
     */
    public function prepareShipment($qtys = array())
    {
        $shipment = Mage::getModel('sales/service_order', $this)->prepareInvoice($qtys);
        return $shipment;
    }

it becomes immediately clear that a copy & paste has gone wrong. Instead of prepareInvoice we need prepareShipment:

    /**
     * Create new shipment with maximum qty for shipping for each item
     *
     * @return Mage_Sales_Model_Order_Shipment
     */
    public function prepareShipment($qtys = array())
    {
        $shipment = Mage::getModel('sales/service_order', $this)->prepareShipment($qtys);
        return $shipment;
    }

From my initial investigation so far only shipments created through the API are affected since the back-end calls the service_order model directly and doesn’t go via the order object.

Link to Bug report.

The only upside is that likely another bug in relation to the API would have prevented you from using it – see.

Originally published on magebase.com. Copyright © 2010 Magebase - All Rights Reserved.